1. Advertising
    y u no do it?

    Advertising (learn more)

    Advertise virtually anything here, with CPM banner ads, CPM email ads and CPC contextual links. You can target relevant areas of the site and show ads based on geographical location of the user if you wish.

    Starts at just $1 per CPM or $0.10 per CPC.

WIll no longer pass W3C HTML validate

Discussion in 'Co-op Advertising Network' started by vauge, Nov 24, 2004.

  1. #1
    Just updated to the new ad_network.php and went to do an HTML verification here:
    WDG HTML Validator

    this is what I get:

    
    Errors
    
        * Line 297, character 148:
    
    ... -real-estate-agents.org" id="h83jd7hf">Realtor</a> || <a hre ...
    
         [B] Error: ID H83JD7HF already defined[/B]
        * Line 297, character 54:
    
    ... source-book-reviews.com" id="h83jd7hf">Open Source Book Revi ...
                                     ^
    
          ID H83JD7HF first defined here
        * Line 297, character 267:
    
    ... ersicherungsanalyse.php" id="8dhf2kjj">Krankenversicherungsa ...
                                     ^
    
          [B]Error: value of attribute ID must start with a letter, not 8[/B]
        * Line 297, character 434:
    
    ... ww.bleepingcomputer.com" id="h83jd7hf">Computer tutorials fo ...
                                     ^
    
          Error: ID H83JD7HF already defined
        * Line 297, character 54:
    
    ... source-book-reviews.com" id="h83jd7hf">Open Source Book Revi ...
                                     ^
    
          ID H83JD7HF first defined here
    
    Code (markup):

    SEMrush
     
    vauge, Nov 24, 2004 IP
    SEMrush
  2. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #2
    Not sure if that's going to be able to be fixed or not to be honest.
     
    digitalpoint, Nov 24, 2004 IP
  3. vauge

    vauge Well-Known Member

    Messages:
    81
    Likes Received:
    2
    Best Answers:
    0
    Trophy Points:
    138
    #3
    Will this hurt my serps by not being able to be HTML validated?
     
    vauge, Nov 24, 2004 IP
  4. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #4
    Hehehe, uhm no.
     
    digitalpoint, Nov 24, 2004 IP
  5. vauge

    vauge Well-Known Member

    Messages:
    81
    Likes Received:
    2
    Best Answers:
    0
    Trophy Points:
    138
    #5
    Cool, I had read on another thread that it could be a factor.
     
    vauge, Nov 24, 2004 IP
  6. Arnica

    Arnica Peon

    Messages:
    320
    Likes Received:
    14
    Best Answers:
    0
    Trophy Points:
    0
    #6
    Hi Shawn

    Must admit I hadn't picked up the non-validation (well spotted vauge). It will certainly put many of my clients off joining the network as they insist on validation of any html, css, etc.

    Is there any chance of prepending a random four (or more) character string to the id that you can programmatically strip out prior to your ad validation? That way the html would validate and the chances of duplicate ids greatly reduced.

    Here's hoping.

    Mick
     
    Arnica, Nov 25, 2004 IP
  7. SEbasic

    SEbasic Peon

    Messages:
    6,318
    Likes Received:
    318
    Best Answers:
    0
    Trophy Points:
    0
    #7
    Why don't you just serve the plain text links if it's an issue?
     
    SEbasic, Nov 25, 2004 IP
  8. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #8
    Yeah... I've thought a little bit about it, and probably will do something like prepend some sort of timestamp to the beginning so it validates.
     
    digitalpoint, Nov 25, 2004 IP
  9. Arnica

    Arnica Peon

    Messages:
    320
    Likes Received:
    14
    Best Answers:
    0
    Trophy Points:
    0
    #9
    Thanks Shawn

    That would be great!

    Hi SEBasic

    The validation issue affects all ad network ads - the current implementation uses the id attribute of the <a> tag to store a ad identifier that Shawn uses to validate the ads. These id's can start with a digit which is illegal in the html specification and can also be duplicated if running multiple ads (again this is against specification). It really isn't an issue as far as any browser being able to display or interpret the html just a pain when some smarta**s duly informs you that every page on your site doesn't validate (slightly more of a pain when a client who paid for a validated site demands an explanation of why their site no longer validates :eek: ).

    Mick
     
    Arnica, Nov 25, 2004 IP
  10. SEbasic

    SEbasic Peon

    Messages:
    6,318
    Likes Received:
    318
    Best Answers:
    0
    Trophy Points:
    0
    #10
    Oh... :rolleyes:
    Is this with the revised code that shawn released?

    I must implement that...
     
    SEbasic, Nov 25, 2004 IP
  11. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #11
    Well, one thing I don't like about the timestamp, is it makes ad network ads easily identifiable. Even if you prepend it with some string it's not good I think.
     
    digitalpoint, Nov 25, 2004 IP
  12. Arnica

    Arnica Peon

    Messages:
    320
    Likes Received:
    14
    Best Answers:
    0
    Trophy Points:
    0
    #12
    How about assigning the current identifier to the class attribute instead?

    Mick
     
    Arnica, Nov 25, 2004 IP
  13. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #13
    That's a thought I had as well. Anyone have any objections to this?
     
    digitalpoint, Nov 25, 2004 IP
  14. Arnica

    Arnica Peon

    Messages:
    320
    Likes Received:
    14
    Best Answers:
    0
    Trophy Points:
    0
    #14
    It might be a problem for people that may be splicing in a class attribute before rendering the ad but any css could (and probably should) be applied by wrapping the links in a <div> anyway.
     
    Arnica, Nov 25, 2004 IP
  15. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #15
    Well I'm not worried about that scenario, because people shouldn't be altering the ad network ad to begin with.
     
    digitalpoint, Nov 25, 2004 IP
  16. SEbasic

    SEbasic Peon

    Messages:
    6,318
    Likes Received:
    318
    Best Answers:
    0
    Trophy Points:
    0
    #16
    I can't see it causing any problems.

    Shawn, could we then convert the banners into pure css?
    It would reduce the size of the output (Not by a lot but it's something) and would also be a lot easier to apply styles to.
     
    SEbasic, Nov 25, 2004 IP
  17. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #17
    If someone wants to give me the code, I'll look at it, but I'm a programmer, not an HTML guy. :)
     
    digitalpoint, Nov 25, 2004 IP
  18. SEbasic

    SEbasic Peon

    Messages:
    6,318
    Likes Received:
    318
    Best Answers:
    0
    Trophy Points:
    0
    #18
    This is the current output
    <table bgcolor=#CCCCCC cellpadding=0 cellspacing=0 width=466 height=58>
    <tr>
    <td align=center valign=middle>
    <b><a href="LINK URL">ANCHOR TEXT</a></b><br>
    <font size=-1>HERE IS WHERE THE DESCRIPTION GOES</font>
    </td>
    </tr>
    </table>
    Code (markup):
    This could be replaced by:
    <div class="CONTAININGLAYER">
    <a href="LINK" class="IDENTIFIER">ANCHOR TEXT</a>
    <span class="DESCRIPTION">HERE IS WHERE THE DESCRIPTION GOES</span>
    </div>
    Code (markup):
     
    SEbasic, Nov 26, 2004 IP
  19. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,297
    Likes Received:
    2,602
    Best Answers:
    461
    Trophy Points:
    710
    Digital Goods:
    29
    #19
    Except that (by itself) doesn't make it 468x60.
     
    digitalpoint, Nov 26, 2004 IP
  20. SEbasic

    SEbasic Peon

    Messages:
    6,318
    Likes Received:
    318
    Best Answers:
    0
    Trophy Points:
    0
    #20
    .CONTAININGLAYER {
          width: 468px;
          height: 60px;
          background-color: #ccc;
          border: 1px solid black;
          text-align: center;
          font-family: verdana, sans-serif;
    }
    Code (markup):
    (I think that's all correct)..
     
    SEbasic, Nov 26, 2004 IP