Stuck at Finishing Point

Discussion in 'JavaScript' started by vishalonne, Jul 30, 2012.

0
  1. #1
    I have made lots of changes in my code and I'm almost reched at the finish point but I stuck at finish line. Error checking is working fine but if there is no error then after clicking on submit button insertform.php page is not opening (means Action attribute of form tag is not working) please help me in solving this -
    This the form.php page where validation is happening -

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <title>Your Valuable Suggestion</title>
    <link rel="stylesheet" type="text/css" href="view.css" media="all" />
    <script type="text/javascript" src="registration.js"></script>
    <script type="text/javascript" src="view.js"></script>
    </head>
    <body id="main_body" >
    <img id="top" src="top.png" alt="">
    <div id="form_container">
    <form id="form_453570" class="appnitro" name="registration" method="post" action="insertform.php" onSubmit="return formValidation(this)">
    <div class="form_description">
    <label class="description" for="element_12">First Name <font color="#EC0006">*</font> </label>
    <div> <input id="element_12" name="element_12" class="element text large" type="text" maxlength="255" value=""/>
    <div id="fnTextBox"></div>
    </div>
    <label class="description" for="element_13">Last Name <font color="#EC0006">*</font></label>
    <div> <input id="element_13" name="element_13" class="element text large" type="text" maxlength="255" value=""/>
    <div id="lnTextBox"></div>
    </div>
    <label class="description" for="element_5">Email <font color="#EC0006">*</font></label>
    <div>
    <input id="element_5" name="element_5" class="element text large" type="text" maxlength="255" value=""/>
    <div id="emTextBox"></div>
    </div>
    <label class="description" for="element_11">Sex <font color="#EC0006">*</font></label>
    <span>
    <input id="element_11_1" name="element_11" class="element radio" type="radio" value="1" />
    <label class="choice" for="element_11_1">Male</label>
    <input id="element_11_2" name="element_11" class="element radio" type="radio" value="2" />
    <label class="choice" for="element_11_2">Female</label>
    </span>
    <div id="sxRadio"></div>
    <label class="description" for="element_1">School Name <font color="#EC0006">*</font></label>
    <div>
    <input id="element_1" name="element_1" class="element text large" type="text" maxlength="255" value=""/>
    <div id="snTextBox"></div>
    </div>
    <input type="hidden" name="form_id" value="453570" />
    <input id="saveForm" class="button_text" type="submit" name="submit" value="Submit" />
    </form>
    <div id="footer"></div>
    </div>
    <img id="bottom" src="bottom.png" alt="">
    </body>
    </html>

    Here is the code of registration.js
    function formValidation()
    {
    var fn = document.registration.element_12;
    var ln = document.registration.element_13;
    var sx = document.registration.element_11;
    var sn = document.registration.element_1;
    if(fname_validation(fn,5)){
    if(lname_validation(ln,5)){
    if(ValidateEmail(em)){
    if(validsex(sx)){
    if(validSchoolName(sn)){
    }
    }
    }
    }
    }
    return false;
    }
    function fname_validation(fn,mx){
    var letters = /^[A-Za-z]+$/;
    var fn_len = fn.value.length;
    if (fn_len == 0 || fn_len < mx) {
    document.getElementById('fnTextBox').innerHTML = "Enter your First name/ Minimum length is 5 characters ";
    fn.focus();
    return false;
    }
    if(fn.value.match(letters)) {
    return true;
    }
    else {
    document.getElementById('fnTextBox').innerHTML = "Name must not contain other than alphabet";
    fn.focus();
    return false; //alert("User Id should not be empty / length be between "+mx+" to "+my);
    }
    return true;
    }

    function lname_validation(ln,mx){
    var letters = /^[A-Za-z]+$/;
    var ln_len = ln.value.length;
    if (ln_len == 0 || ln_len < mx) {
    document.getElementById('lnTextBox').innerHTML = "Enter your Last name/ Minimum length is 5 characters ";
    ln.focus();
    return false;
    }
    if(ln.value.match(letters)){
    return true;
    }
    else{
    document.getElementById('lnTextBox').innerHTML = "Name must not contain other than alphabet";
    ln.focus();
    return false; //alert("User Id should not be empty / length be between "+mx+" to "+my);
    }
    return true;
    }

    function validsex(sx){
    if(!(sx[0].checked || sx[1].checked)){
    document.getElementById('sxRadio').innerHTML = "Select your Sex";
    sx[0].focus();
    return false;
    }
    return true;
    }

    function ValidateEmail(em){
    var mailformat = /^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/;
    if(em.value.match(mailformat)){
    return true;
    }
    else{
    document.getElementById('emTextBox').innerHTML = "Enter Valid EMail ID";
    em.focus();
    return false;
    }
    }

    function validSchoolName(sn){
    var sn_len = sn.value.length;
    if (sn_len == 0){
    document.getElementById('snTextBox').innerHTML = "Enter your School Name";
    sn.focus();
    return false;
    }
    return true;
    }
     

    Attached Files:

    vishalonne, Jul 30, 2012 IP
  2. flotwig

    flotwig Peon

    Messages:
    39
    Likes Received:
    1
    Best Answers:
    2
    Trophy Points:
    0
    #2
    Your input validation function is returning false, causing the form not to submit.
     
    flotwig, Jul 30, 2012 IP
  3. vishalonne

    vishalonne Member

    Messages:
    51
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    41
    #3
    Hi Flotwig

    Thank you for looking to my problem...!
    I am new in this field after reading lots of artical I came up with this. After so many work it is returning false from where/how.
    Can you please help me in patching the error
     
    vishalonne, Jul 30, 2012 IP
  4. flotwig

    flotwig Peon

    Messages:
    39
    Likes Received:
    1
    Best Answers:
    2
    Trophy Points:
    0
    #4
    Inside the formValidation() function. Make it return true instead.
     
    flotwig, Jul 30, 2012 IP
  5. vishalonne

    vishalonne Member

    Messages:
    51
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    41
    #5
    My previous code -
    function formValidation()
    {
    var fn = document.registration.element_12;
    var ln = document.registration.element_13;
    var sx = document.registration.element_11;
    var sn = document.registration.element_1;
    if(fname_validation(fn,5)){
    if(lname_validation(ln,5)){
    if(ValidateEmail(em)){
    if(validsex(sx)){
    if(validSchoolName(sn)){
    }
    }
    }
    }
    }
    return false;
    }
    My modified code -
    function formValidation()
    {
    var fn = document.registration.element_12;
    var ln = document.registration.element_13;
    var sx = document.registration.element_11;
    var sn = document.registration.element_1;
    if(fname_validation(fn,5)){
    if(lname_validation(ln,5)){
    if(ValidateEmail(em)){
    if(validsex(sx)){
    if(validSchoolName(sn)){
    }
    }
    }
    }
    }
    return true;
    }
    But no effect, only fields are getting cleared and if I make mistake it going on next page i.e. on insertform.php
     
    vishalonne, Jul 30, 2012 IP
  6. flotwig

    flotwig Peon

    Messages:
    39
    Likes Received:
    1
    Best Answers:
    2
    Trophy Points:
    0
    #6
    function formValidation()
    {
    var fn = document.registration.element_12;
    var ln = document.registration.element_13;
    var sx = document.registration.element_11;
    var sn = document.registration.element_1;
    if(fname_validation(fn,5)){
    if(lname_validation(ln,5)){
    if(ValidateEmail(em)){
    if(validsex(sx)){
    if(validSchoolName(sn)){
    return true;
    }
    }
    }
    }
    }
    return false;
    }
     
    flotwig, Jul 30, 2012 IP
  7. vishalonne

    vishalonne Member

    Messages:
    51
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    41
    #7
    Hi Flotwig
    As per your instruction I made changes but now the problem is even if don't leave fields blank and fill them after getting error message (if previously left blank) error message are still displayed over there
     
    Last edited: Jul 30, 2012
    vishalonne, Jul 30, 2012 IP
  8. vishalonne

    vishalonne Member

    Messages:
    51
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    41
    #8
    Thank you Flotwig every thing working fine....!
    How can I get rid of these error message?
     
    vishalonne, Jul 30, 2012 IP