Registration form submit button not working

Discussion in 'HTML & Website Design' started by ydubel, Aug 23, 2007.

  1. #1
    The new user registration (can't post live link for "comfusion.us" ) isn't working....submit button doesn't work but the cancel does.

    Can you take a look and tell me what is causing this and how i might be able to fix it?

    Thanks in advance for your help!
     
    ydubel, Aug 23, 2007 IP
  2. krt

    krt Well-Known Member

    Messages:
    829
    Likes Received:
    38
    Best Answers:
    0
    Trophy Points:
    120
    #2
    if(isEmail(document.register.email)){document.register.email.value='';document.register.email.focus();return false;}

    That should be:

    if (!isEmail(document.register.email)) { alert('Invalid email'); document.register.email.value=''; document.register.email.focus(); return false;}

    Some suggestions
    - add a "skip intro" link
    - make the "enter" link more obvious
    - allow user to have numbers/symbols in password
    - review other validation rules
    - don't erase the field if a user makes a mistake in it
     
    krt, Aug 23, 2007 IP
  3. ydubel

    ydubel Peon

    Messages:
    7
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    0
    #3
    Thanks for the submit diagnosis. Very much appreciated :)

    We're plugging in another picture based on plans for the actual "in world" space so i'm waiting to see how that works before changing any of the other layers.

    I had thought of some of the things you mention but i don't know how to change the validation rules. One of the issues was that when you click submit the email field is cleared. This is still happening and i did replace the line you suggested in the js file. Any other suggestions?

    I also didn't want to require street address and phone number, can you tell me how i change that?

    So just in case you can help i've posted the validation_forms. js file contents below.

    // JavaScript Document
    function validate()
    {
    if(isEmpty(document.register.username,'User Name')||isAlphabet(document.register.username,'User Name'))
    { document.register.username.focus(); return false; }
    if(isEmpty(document.register.password,'Password')||isAlphabet(document.register.username,'Password'))
    { document.register.password.focus(); return false; }
    if(isEmpty(document.register.con_password,'Confirm Password')||isAlphabet(document.register.con_password,'Confirm Password'))
    { document.register.con_password.focus(); return false; }
    if(document.register.con_password.value != document.register.password.value){
    alert('Password and Confirm Password are not same');document.register.con_password.value='';
    document.register.con_password.focus(); return false;}
    if(isEmpty(document.register.fname,'First Name')||isAlphabet(document.register.fname,'First Name'))
    { document.register.fname.focus(); return false;}
    if(isEmpty(document.register.lname,'Last Name')||isAlphabet(document.register.lname,'Last Name'))
    { document.register.lname.value=""; return false;}
    if(isEmpty(document.register.address,'Address'))
    { document.register.address.focus(); return false;}
    if(isEmpty(document.register.city,'City'))
    { document.register.city.focus(); return false;}
    if(isEmpty(document.register.state,'State'))
    { document.register.state.focus(); return false;}
    if(document.register.country.value==0)
    {alert('Please Select the Country'); document.register.country.focus(); return false;}
    if(isEmpty(document.register.zipcode,'zipcode') || isNumeric(document.register.zipcode,'zipcode'))
    { document.register.zipcode.value='';document.register.zipcode.focus(); return false;}
    if(isEmpty(document.register.phone_number,'Phone Number') || isNumeric(document.register.phone_number,'Phone Number'))
    { document.register.phone_number.value='';document.register.phone_number.focus(); return false;}
    if(isEmpty(document.register.mobile_number,'Mobile Number') || isNumeric(document.register.mobile_number,'Mobile Number'))
    { document.register.mobile_number.value='';document.register.mobile_number.focus(); return false;}
    if(document.register.email.value==''){alert('Please Enter Email id');document.register.email.focus(); return false;}
    if (validate_email(document.register.email,"Not a valid e-mail address!")==false)
    {document.register.email.value='';
    document.register.email.focus();return false;}
    if (!isEmail(document.register.email)) { alert('Invalid email'); document.register.email.value=''; document.register.email.focus(); return false;}

    }
     
    ydubel, Aug 23, 2007 IP
  4. krt

    krt Well-Known Member

    Messages:
    829
    Likes Received:
    38
    Best Answers:
    0
    Trophy Points:
    120
    #4
    // JavaScript Document
    function validate()
    {
    if(isEmpty(document.register.username,'User Name'))
    { document.register.username.focus(); return false; }
    if(isEmpty(document.register.password,'Password'))
    { document.register.password.focus(); return false; }
    if(isEmpty(document.register.con_password,'Confirm Password'))
    { document.register.con_password.focus(); return false; }
    if(document.register.con_password.value != document.register.password.value){
    alert('Password and Confirm Password are not same');document.register.con_password.value='';
    document.register.con_password.focus(); return false;}
    if(isEmpty(document.register.fname,'First Name')||isAlphabet(document.register.fname,'First Name'))
    { document.register.fname.focus(); return false;}
    if(isEmpty(document.register.lname,'Last Name')||isAlphabet(document.register.lname,'Last Name'))
    { document.register.lname.value=""; return false;}
    if(isEmpty(document.register.city,'City'))
    { document.register.city.focus(); return false;}
    if(isEmpty(document.register.state,'State'))
    { document.register.state.focus(); return false;}
    if(document.register.country.value==0)
    {alert('Please Select the Country'); document.register.country.focus(); return false;}
    if(isEmpty(document.register.zipcode,'zipcode') || isNumeric(document.register.zipcode,'zipcode'))
    { document.register.zipcode.value='';document.register.zipcode.focus(); return false;}
    if(document.register.email.value==''){alert('Please Enter Email id');document.register.email.focus(); return false;}
    if (validate_email(document.register.email,"Not a valid e-mail address!")==false)
    {document.register.email.focus();return false;}
    
    }
    Code (markup):
    Please note I done the changes in a rush. I hope it works. It should cover most of the changes including taking out req't for street address / phone numbers. I also took out some "alphabet" requirements.
     
    krt, Aug 23, 2007 IP