Log in or Sign up

PHP form valitaion and submit

Discussion in 'PHP' started by ott, Nov 30, 2012.

Page 2 of 2

ott Greenhorn

Messages:

16

Likes Received:

0

Best Answers:

0

Trophy Points:

11

#21

deathshadow said: ↑

some observations here:

1.
--------------------------------
if($_POST)

$_POST is a superglobal, it always exists even when empty. Statement does nothing as it's always true.

2.
--------------------------------
$first_name = $_POST['first_name'];
$last_name = $_POST['last_name'];
$phone = $_POST['phone'];
$email = $_POST['email'];
etc, etc, etc...

Do not waste time making copies of existing variables for no good reason. Complete waste of memory and overhead.

3.
--------------------------------
// First Name
if (preg_match("/^[A-Za-z -]{3,20}$/",$first_name))
{
$valid_first_name=$first_name;
}
else
{
$error_first_name='Enter valid First Name.';
}

You do a bunch of these in a row, it would be easier to use the same code on the array and iterate the array.

4.
--------------------------------
<form autocomplete="off"
enctype="multipart/form-data" method="post" action="" name="form">
<ul>
<li id="foli1" class=" ">

What makes this a list? The answer? NOTHING. These are not bullet points. There is likely no reason for the list, the extra DIV around the inputs, all the extra ID's, the redundant id's, etc, etc...

5.
--------------------------------
<label class="desc" id="title1" for="Field1">
First Name </label>
<div>
<input id="first_name" name="first_name" type="text" class="field text medium" value="<?php echo $valid_first_name; ?>" maxlength="255" tabindex="1" />

there is no reason to have an ID on the label, a class on the label, and the FOR attribute points at an ID, so that should read for="first_name"... likewise there is likely little reason to need three classes on the input (if any), and it generally helps to NOT open and close PHP willy nilly and instead use a command like ECHO for cleaner output... also if you have to use tabindex, there's probably something wrong with how the page is being built.

Though the Doctype alone proudly proclaims there's something wrong -- Transitional, which is to say you are in transition from 1997 to 1998 coding practices!

From what I'm seeing you have over 400 lines of code doing the job of a quarter that. I'm away from the workstation right now, but when I'm back on it and have some time I'll toss together a quick rewrite to show you what I mean and a cleaner method for handling that.
Click to expand...

Thank you! I know it isn't very pretty, I'm a bit new to PHP. I can read through most of what I see but I still get a little mixed up on it. The code, html and php, came from an example on how to do this and I hadn't modified the html portion because I'm mainly just worried about getting the validate then post part to work.
I'm trying to get it to imitate what this page here does, when you have javascript disabled. http://allstatescartransport.com/car-transport.html

ott, Dec 5, 2012 IP

(You must log in or sign up to reply here.)

Page 2 of 2