Onmouseover help please

I don't know much about javascript but i am trying to add an image. I did not create the site but i am trying to edit it at my work.

My question is i know the onmouseover code is wrong, what is the right code?

Ignore it not being closed but when i try and replace the image it doesn't work, ive tried to look up different ways on the net but no luck.
pay close attention to the ON MOUSE OVER part. thanks

 

Try changing this

<img name="imgAbout" src="images/ban2.jpg" border="0" />

Code (markup):

to this

<img id="imgAbout" src="images/ban2.jpg" border="0" />

Code (markup):

And then use replace all "document.imgAbout" with "document.getElementById('imgAbout')"

 

Thank you very much, worked fine

 

Happy that it helped and thanks for the rep.

 

Is that in-line JavaScript I see? That's disgusting! Separate your code and use external JavaScript or at least keep your JavaScript code in its own tags. Using this:

<input type="text" id="testing" onmouseover="" />

Code (markup):

... is archaic! Instead, use this:

<script type="text/javascript">

document.getElementById("testing").addEventListener("mouseover", some_function, false);

function some_function()
{
    // Do something
}

</script>

<input type="text" id="testing" />

Code (markup):

I know it looks like more work to begin with, but you can make this function generic and have it work with all your HTML <li> elements by virtue of the JavaScript target.id/srcElement.id (standards-compliant, MSIE, respectively).

 

While to me, it looks like you're using javascript to do CSS' job, but I'd have to actually see what it is you're even trying to do on a page, or at very least the CSS already being applied to say for sure how to go about that.

Also, much of that doesn't look like a job for lists... or at least not multiple lists.

Since you're using the same images on all of them though, that really should probably be a image declared in the CSS on a sandbag type span that you apo over the the sibling image -- assuming that said IMG should even be there in the first place given that none of it looks like it's content.

I mean, you're just changing style on hover, this isn't 1998... you don't need scripting for that.

 

Thanks for your input. I actually did not write the code, im very new to coding and only really know xhtml. I was just helping "adjust" the site at work.
The code was written by a guy who is friends with my boss.

 

Thanks for your input. I actually did not write the code, im very new to coding and only really know xhtml. I was just helping "adjust" the site at work.
The code was written by a guy who is friends with my boss.
I'm actually 21 and so I wouldn't know about coding in 1998

 

thread can be closed