Onchange validation problem

Hi Everyone,

I am trying to create a simple form validation using the onchange property. However it seems to be not working. I have almost no experience in javascript so I probably made a simple mistake. Anyways below is my code, any help is appreciated.

<form method="post" name="PasswordChange" action="usercp.php?action=<?php echo(md5("passwordchange")); ?>">
		<table border="0" align="center" width="300px">
			<tr><td>Old Password: </td>
			<td align="center"><input type="password" name="OldPass"/></td></tr>
			
			<tr><td>New Password: </td>
			<td align="center"><input type="password" name="NewPass"/></td></tr>
			
			<tr><td>Repeat New Password: </td>
			<td align="center"><input type="password" name="PassRepeat" onchange="return CheckPass();" /></td></tr>
			
			<tr><td colspan="2" align="center"><br/><input type="submit" value="Update Password"/></td></tr>
		</table>
	</form>

HTML:

Below is my javscript that corresponds to the form

<script type="text/javascript">
 
	function CheckPass(){
		var NewPass;
		var PassRepeat;
		
		NewPass = document.getElementById["PasswordChange"]["NewPass"].value
		PassRepeat = document.getElementById["PasswordChange"]["PassRepeat"].value
		
		if(NewPass != PassRepeat) {
			alert("Your passwords did not match up. Please try again.");
			return true;
		}else{
			return false;
		}
	}
</script>

Code (markup):

Thanks in advance!

 

It should be

NewPass = document.forms["PasswordChange"].elements["NewPass"].value
PassRepeat = document.forms["PasswordChange"].elements["PassRepeat"].value

Code (markup):

 

Thanks, that worked like a charm!