need advice on whether or not i have covered everything correctly or missed anything. feedback appreciated