new my script What do you think؟

Discussion in 'PHP' started by t6werserv, Feb 2, 2010.

  1. #1
    What do you think of this in the script?
    I produced


    Visit PL
     
    t6werserv, Feb 2, 2010 IP
  2. danx10

    danx10 Peon

    Messages:
    1,179
    Likes Received:
    44
    Best Answers:
    2
    Trophy Points:
    0
    #2
    A few possible improvements, on your form:

    1. Add email validation on the email input. (Return an error message if it is'nt valid, you could possibly use regular expressions)

    2. Check if the domain of the 'File Link' exists before creating the unique url. (Return an error message if it doesn't exist, you can possibly use php's parse_url() then -> checkdnsrr() function for this)

    3. The visitor shouldn't have to input the file size, - it can sometimes be wrong (you could possibly use php's filesize() function, on the 'File Link' location, which is more reliable)

    4. Validate the 'File Link' format (Return an error message if it is'nt valid, you could possibly use regular expressions)

    5. Use php's strip_tags() function on all your input fields, I was able to make the 'File Name' as html.

    Suggestion:

    1. You can use .htaccess to make your url/s smaller and possibly even seo friendly; like http://t6wer-serv.net/pl/index.php?77451487 would turn into -> http://t6wer-serv.net/out/77451487 (example url format)
     
    Last edited: Feb 2, 2010
    danx10, Feb 2, 2010 IP
  3. t6werserv

    t6werserv Peon

    Messages:
    32
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    0
    #3
    thank Your words and suggestions, but who is work of example url format number only?
     
    t6werserv, Feb 2, 2010 IP