need help with code

Discussion in 'HTML & Website Design' started by imsoflyoh, Dec 9, 2007.

  1. #1
    i need help with this code if there is something wrong with this code tell me it is just not showing right on the web site the site is www.simplyblessed.ws (cant put as link not member for 7 days yet)here is the code

    <html>
    <head>
    <style>
    .spanstyle {
    position:absolute;
    visibility:visible;
    top:-50px;
    font-size:10pt;
    font-family:Verdana;
    font-weight:bold;
    color:black;
    }
    </style>

    <style type="text/css">
    body
    {background-image:
    url('http://i163.photobucket.com/albums/t282/spongyboy_2007/ummmcool.jpg')}
    h1,h2 {color: #33FF99}
    div.background
    {
    width: 1050px;
    height: 550px;
    background: url('http://i163.photobucket.com/albums/t282/spongyboy_2007/banner.jpg');
    border: 2px solid black;
    background-repeat: no repeat;
    background-position: 30% 20%;}
    div.transbox
    {
    width: 900px;
    height: 500px;
    margin: 30px 50px;
    background-color: #ffffff;
    border: 1px solid black;
    /* for IE */
    filter:alpha(opacity=60);
    /* CSS3 standard */
    opacity:0.6;
    /* for Mozilla */
    -moz-opacity:0.6;
    }
    div.transbox p
    {
    margin: 30px 40px;
    font-weight: bold;
    color: #000000;
    }
    h1,h2 {font-family: arial}
    </style>
    </head><body><div class="background">
    <script>
    <!-- Beginning of JavaScript -

    for (i=0;i<=message.length-1;i++) {
    document.write("<span id='span"+i+"' class='spanstyle'>")
    document.write(message)
    document.write("</span>")
    }

    if (document.layers){
    document.captureEvents(Event.MOUSEMOVE);
    }
    document.onmousemove = handlerMM;

    // - End of JavaScript - -->
    </script>
    <div class="transbox">
    <h1><font size="4">the Computer squad. </font></h1>
    <h1><font size="4">FAST ONSITE TECH SUPPORT FOR RESIDENTIAL AND SMALL BUSINESS!
    </font></h1>
    <script language="JavaScript1.2">
    //Translucent scroller- By Dynamic Drive
    //For full source code and more DHTML scripts, visit http://www.dynamicdrive.com
    //This credit MUST stay intact for use
    var scroller_width='150px'
    var scroller_height='115px'
    var bgcolor='#E0EFD1'
    var pause=3000 //SET PAUSE BETWEEN SLIDE (3000=3 seconds)
    var scrollercontent=new Array()
    //Define scroller contents. Extend or contract array as needed
    scrollercontent[0]='want to fix your computer'
    scrollercontent[1]='you dont know what to do when somthing goes rong.'
    scrollercontent[2]='just call or email us at (your email here). '
    ////NO need to edit beyond here/////////////
    var ie4=document.all
    var dom=document.getElementById&&navigator.userAgent.indexOf("Opera")==-1
    if (ie4||dom)
    document.write('<div style="position:relative;width:'+scroller_width+';height:'+scroller_height+';overflow:hidden"><div id="canvas0" style="position:absolute;background-color:'+bgcolor+';width:'+scroller_width+';height:'+scroller_height+';top:'+scroller_height+';filter:alpha(opacity=20);-moz-opacity:0.2;"></div><div id="canvas1" style="position:absolute;background-color:'+bgcolor+';width:'+scroller_width+';height:'+scroller_height+';top:'+scroller_height+';filter:alpha(opacity=20);-moz-opacity:0.2;"></div></div>')
    else if (document.layers){
    document.write('<ilayer id=tickernsmain visibility=hide width='+scroller_width+' height='+scroller_height+' bgColor='+bgcolor+'><layer id=tickernssub width='+scroller_width+' height='+scroller_height+' left=0 top=0>'+scrollercontent[0]+'</layer></ilayer>')
    }
    var curpos=scroller_height*(1)
    var degree=10
    var curcanvas="canvas0"
    var curindex=0
    var nextindex=1
    function moveslide(){
    if (curpos>0){
    curpos=Math.max(curpos-degree,0)
    tempobj.style.top=curpos+"px"
    }
    else{
    clearInterval(dropslide)
    if (crossobj.filters)
    crossobj.filters.alpha.opacity=100
    else if (crossobj.style.MozOpacity)
    crossobj.style.MozOpacity=1
    nextcanvas=(curcanvas=="canvas0")? "canvas0" : "canvas1"
    tempobj=ie4? eval("document.all."+nextcanvas) : document.getElementById(nextcanvas)
    tempobj.innerHTML=scrollercontent[curindex]
    nextindex=(nextindex<scrollercontent.length-1)? nextindex+1 : 0
    setTimeout("rotateslide()",pause)
    }
    }
    function rotateslide(){
    if (ie4||dom){
    resetit(curcanvas)
    crossobj=tempobj=ie4? eval("document.all."+curcanvas) : document.getElementById(curcanvas)
    crossobj.style.zIndex++
    if (crossobj.filters)
    document.all.canvas0.filters.alpha.opacity=document.all.canvas1.filters.alpha.opacity=20
    else if (crossobj.style.MozOpacity)
    document.getElementById("canvas0").style.MozOpacity=document.getElementById("canvas1").style.MozOpacity=0.2
    var temp='setInterval("moveslide()",50)'
    dropslide=eval(temp)
    curcanvas=(curcanvas=="canvas0")? "canvas1" : "canvas0"
    }
    else if (document.layers){
    crossobj.document.write(scrollercontent[curindex])
    crossobj.document.close()
    }
    curindex=(curindex<scrollercontent.length-1)? curindex+1 : 0
    }
    function resetit(what){
    curpos=parseInt(scroller_height)*(1)
    var crossobj=ie4? eval("document.all."+what) : document.getElementById(what)
    crossobj.style.top=curpos+"px"
    }
    function startit(){
    crossobj=ie4? eval("document.all."+curcanvas) : dom? document.getElementById(curcanvas) : document.tickernsmain.document.tickernssub
    if (ie4||dom){
    crossobj.innerHTML=scrollercontent[curindex]
    rotateslide()
    }
    else{
    document.tickernsmain.visibility='show'
    curindex++
    setInterval("rotateslide()",pause)
    }
    }
    if (ie4||dom||document.layers)
    window.onload=startit
    </script>
    </div>
    </div>
    <script>
    if (!document.layers)
    document.write('<div id="divStayTopLeft" style="position:absolute">')
    </script>

    <layer id="divStayTopLeft">

    <!--EDIT BELOW CODE TO YOUR OWN MENU-->
    <table border="1" width="130" cellspacing="0" cellpadding="0">
    <tr>
    <td width="100%" bgcolor="#FFFFCC">
    <p align="center"><b><font size="4">Menu</font></b></td>
    </tr>
    <tr>
    <td width="100%" bgcolor="#FFFFFF">
    <p align="left"> <a href="http://thecomputer-squad.com/pb/wp_fcb5d134/wp_fcb5d134.html?0.3916503883694483">services</a><br>
    <a href="http://thecomputer-squad.com/pb/wp_cb7cb573/wp_cb7cb573.html?0.5711045581200995">About us</a><br>
    <a href="http://thecomputer-squad.com/pb/wp_67c14822/wp_67c14822.html?0.5938779141083146">Contact us</a><br>
    <a href="http://thecomputer-squad.com/index.html?0.23849862888763834">home</a></td>
    </tr>
    </table>
    <!--END OF EDIT-->

    </layer>


    <script type="text/javascript">

    /*
    Floating Menu script- Roy Whittle (http://www.javascript-fx.com/)
    Script featured on/available at http://www.dynamicdrive.com/
    This notice must stay intact for use
    */

    //Enter "frombottom" or "fromtop"
    var verticalpos="frombottom"

    if (!document.layers)
    document.write('</div>')

    function JSFX_FloatTopDiv()
    {
    var startX = 3,
    startY = 150;
    var ns = (navigator.appName.indexOf("Netscape") != -1);
    var d = document;
    function ml(id)
    {
    var el=d.getElementById?d.getElementById(id):d.all?d.all[id]:d.layers[id];
    if(d.layers)el.style=el;
    el.sP=function(x,y){this.style.left=x;this.style.top=y;};
    el.x = startX;
    if (verticalpos=="fromtop")
    el.y = startY;
    else{
    el.y = ns ? pageYOffset + innerHeight : document.body.scrollTop + document.body.clientHeight;
    el.y -= startY;
    }
    return el;
    }
    window.stayTopLeft=function()
    {
    if (verticalpos=="fromtop"){
    var pY = ns ? pageYOffset : document.body.scrollTop;
    ftlObj.y += (pY + startY - ftlObj.y)/8;
    }
    else{
    var pY = ns ? pageYOffset + innerHeight : document.body.scrollTop + document.body.clientHeight;
    ftlObj.y += (pY - startY - ftlObj.y)/8;
    }
    ftlObj.sP(ftlObj.x, ftlObj.y);
    setTimeout("stayTopLeft()", 10);
    }
    ftlObj = ml("divStayTopLeft");
    stayTopLeft();
    }
    JSFX_FloatTopDiv();
    </script>

    </body>
    </html>
    <script type="text/vbscript">
    document.write("Today's date is " & date())
    document.write("<br />")
    document.write("The time is " & time())
    </script>
     
    imsoflyoh, Dec 9, 2007 IP
  2. scottlpool2003

    scottlpool2003 Well-Known Member

    Messages:
    1,708
    Likes Received:
    49
    Best Answers:
    9
    Trophy Points:
    150
    #2
    Hi,

    I've had a quick look at your coding.

    I've edited a bit, but be warned, I'm no expert!



    I'm sure you can figure it out from here! :)
     
    scottlpool2003, Dec 11, 2007 IP
  3. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #3
    Alright, let's work from the top down:

    No Doctype

    Inlined Style

    MULTIPLE inlined styles, there's no reason to open/close like that.

    No title, no character encoding meta

    DHTML output of variables not even defined - I ASSUME you removed a bunch of stuff from the header?

    Output of content before the H1

    MULTIPLE H1's.

    Presentational font tags INSIDE the H1 (this is what CSS is FOR!!!)

    Embedded scroller script - again, this should be linked in - being it's shit from Dynamic drive good luck ever getting it to work or provide 'accessability'

    single column table - Why bother?

    presentational attributes

    Inlined (again for no reason - they're FUNCTIONS) Javascripts providing nothing CSS can't and just making the page hard to follow

    Function that is immediately called ONCE and never called again that is inlined - makes even LESS sense.

    Script output AFTER the BODY and HTML are closed - completely invalid output.

    Wastes code trapping Nutscrape 4

    Script kiddie mess excasterbated by being more 1997 than 2007

    7k of nonsense for what should MAYBE be two and a half k of HTML.

    My advice, chuck it and start over using VALID HTML, separation of presentation from content with PROPER CSS.... and stay the hell away from the CRAP on dynamic drive.
     
    deathshadow, Dec 11, 2007 IP