MYSQL Error? WTF

Discussion in 'PHP' started by Proxyhub, Feb 26, 2008.

  1. #1
    You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' , , )' at line 1
    Code (markup):
    And here is my code.

    
    <?php
    $host = "localhost";
    $dbuser = "a";
    $dbpass = "a";
    $dbname = "cashflik";
    $ip = getenv("REMOTE_ADDR");
    
    $connection = mysql_connect($host, $dbuser, $dbpass);
    $db = mysql_select_db($dbname, $connection);
    
    //grab data from form
    $name = $_POST[username];
    $pass = $_POST[password];
    $pass_conf = $_POST[pass_conf];
    $email = $_POST[email];
    $ip = $_POST[ip];
    
    if($name == false || $pass == false || $pass_conf == false || $email == false){
    echo "Please fill in all the required fields!";
    }
    if($pass != $pass_conf){
    echo "Passwords do not match!";
    }else{
    $connection = mysql_connect($host, $dbuser, $dbpass);
    $db = mysql_select_db($dbname, $connection);
    $sql = "INSERT INTO user (username, password, email, ip) VALUES ( " . $_POST[name] . ", " . $_POST[pass] . ", " . $_POST[email] . ", " . $_POST[ip] . ")";
    //$sql = "INSERT INTO user (username,password,email,ip) VALUES ($_POST[name], $_POST[pass], $_POST[email], $_POST[ip])";
    $result = mysql_query($sql) or die (mysql_error());
    echo "Thank you for your registration to CashFlik.com";
    }
    ?>
    
    Code (markup):
    WTF is going on here?
     
    Proxyhub, Feb 26, 2008 IP
  2. jeff_oneil

    jeff_oneil Peon

    Messages:
    29
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    0
    #2
    You need single quotes ( ' ) around your values:
    $sql = "INSERT INTO user (username, password, email, ip) VALUES ( '" . $_POST[name] . "', '
     
    jeff_oneil, Feb 26, 2008 IP
  3. Proxyhub

    Proxyhub Peon

    Messages:
    909
    Likes Received:
    91
    Best Answers:
    0
    Trophy Points:
    0
    #3
    Thanks, it worked!
     
    Proxyhub, Feb 26, 2008 IP