My new site What do you think?

Discussion in 'Websites' started by sitescripts, Dec 20, 2013.

  1. #1
    sitescripts, Dec 20, 2013 IP
  2. andy999111

    andy999111 Greenhorn

    Messages:
    5
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    11
    #2
    Atrocious. Take it down off the internet immediately. This is worse than the dark days of 2003. Table rows, are you shitting me, son?
     
    andy999111, Dec 20, 2013 IP
  3. sitescripts

    sitescripts Active Member

    Messages:
    600
    Likes Received:
    3
    Best Answers:
    0
    Trophy Points:
    88
    Digital Goods:
    10
    #3
    THanks for your kind words. Means a lot you know? Seems like people just like to troll but you no! Your stand up guy.
     
    sitescripts, Dec 21, 2013 IP
  4. jk.deff

    jk.deff Active Member

    Messages:
    59
    Likes Received:
    7
    Best Answers:
    0
    Trophy Points:
    55
    #4
    I tried to subscribe to the newsletter and got an error
    Deprecated: Function ereg() is deprecated in /home/rfarmer/public_html/thedigitaldollarstore.com/mail.php on line 7

    You need to replace
    ereg() -----> preg_match()

    =====

    Make by javascropt, that the form of subscription became empty when you start writing there emeyl.
    onfocus="if(this.value=='your email') this.value='';"
    Code (markup):
    =====

    Would be nicer if the top menu will change when the mouse over.

    =====

    Try to minimize the number of errors by http://validator.w3.org
    Now You have 50 Errors.

    =====

    I do not see headers (<h1>, <h2>, ...) on your pages. Their presence is important for SEO.

    =====

    Also is important for SEO many unique and interesting content and links from trust resources
     
    Last edited: Dec 21, 2013
    jk.deff, Dec 21, 2013 IP
  5. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #5
    First impression, you have two out of three on the trifecta of /FAIL/ -- specifically a crappy little stripe fixed width layout with inaccessible absurdly undersized fixed metric (px) fonts. NOT a good start. Site title seems to have problesm with it's line-height, with "the" and "store" overlapping each-other. The page has no headings so heading navigation is nonexistant, meaning that people on screen readers and UA's like search engines aren't going to be able to figure out what's what...

    146k in 22 files is within what I consider acceptable limits, but still feels heavy for such a simple page.

    Peeking under the hood you have no doctype so IE is in quirks -- probably why it's inconsistent across browsers. The markup is for all intents and purposes HTML 3.2 circa 1997, with attributes and tags that have no business in any website written after that time! background, leftmargin, cellpadding, align, target -- NONE of that should be present in anything written within the past decade and a half!

    Which is why even though it's only 12k, that's 12k for 1.5k of plaintext meaning about HALF of your markup belongs on the cutting room floor. No joke, I could bring that in at around 6k of markup.

    Given that it's pretty much ALL presentational markup I'm wondering what the devil you even have a stylesheet LINK for, of course with no media targets it's being sent to 'all' -- which I'm so sure screen layout makes sense for print, handheld... aural...

    I also see the garbage scripted popup nonsense, something that reeks of "I can haz intarnets?"

    The use of images for major text sections like menu items and what should be your H2 is also trash.

    Now that said, it is nice to see someone almost use meta[description] and meta[keywords] properly. The Desc is ok, the keywords is the right number and not redundant, it just suffers from them not corresponding to the content of the page and multiple words where inappropriate -- STILL, that's better than what most people do on those.

    Really, what you have needs to be tossed and drag the site kicking and screaming into THIS century.

    Just to give you an idea what I mean, well... this is all you really should have for HTML on the home page:

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
    <html
    	xmlns="http://www.w3.org/1999/xhtml"
    	lang="en"
    	xml:lang="en"
    ><head>
    
    <meta
    	http-equiv="Content-Type"
    	content="text/html; charset=utf-8"
    />
    
    <meta
    	http-equiv="Content-Language"
    	content="en"
    />
    
    <meta
    	name="viewport"
    	content="width=device-width; height=device-height; initial-scale=1.0"
    />
    
    <meta
    	name="description"
    	content="The Only Digital Dollar store online! Webmasters pardise! Get php Scripts, PLR articles, Javscripts, software and more! All at only 1 USD"
    />
    
    <meta
    	name="keywords"
    	content="pardise, PHP, scripts, PLR, articles, javscript, software, webmaster"
    />
    
    
    
    <link
    	type="text/css"
    	rel="stylesheet"
    	href="screen.css"
    	media="screen,projection,tv"
    />
    
    <title>
    	The Webmaster Dollar Store
    </title>
    
    </head><body>
    
    <div id="pageWrapper">
    
    	<h1>
    		The Digital Dollar Store<br />
    		<small>Instant Downloads</small>
    	</h1>
    
    	<ul id="accessMenu">
    		<li>
    			<a href="#mainMenu" accesskey="0" title="Menu">
    				Menu
    			</a>
    		</li><li>
    			<a href="#content" accesskey="1" title="Content">
    				Content
    			</a>
    		</li><li>
    			<a href="#topSellers" accesskey="2" title="Top Sellers">
    				Top Sellers
    			</a>
    		</li><li>
    			<a href="#newsletterSignup" accesskey="6" title="Sign up for Newsletter">
    				Sign up for newsletter
    			</a>
    		</li><li>
    			<a href="#categories" accesskey="7" title="Categories">
    				Categories
    			</a>
    		</li><li>
    			<a href="#links" accesskey="8" title="Links">
    				Links
    			</a>
    		</li><li>
    			<a href="#footer" accesskey="9" title="Footer">
    				Footer
    			</a>
    		</li>
    	</ul>
    
    	<a href="http://www.arvixe.com/6133-0-1-390.html" id="topAdvert">
    		<img
    			src="banners/1387361331_Banner.486.60.gif"
    			alt="Best Hosting"
    		/>
    	</a>
    
    	<ul id="mainMenu">
    		<li><a href="/">Home</a></li>
    		<li><a href="view_cart.php">View Cart</a></li>
    		<li><a href="search.php">Search</a></li>
    		<li><a href="help.php">Help</a></li>
    		<li><a href="contact.php">Contact Us</a></li>
    	</ul>
    
    	<div id="contentWrapper"><div id="content">
    		<h2>Professional Scripts....Exceptional Service!</h2>
    		<p>
    			Welcome to the Internet's top resource for premium scripts. Browse our easy to use website to find the product you are looking for. From professional webmasters to beginners looking to start their first dot com, there is something for everyone.
    		</p>
    		<ul>
    			<li>
    				Professional scripts developed to deliver top notch performance and reliability
    			</li><li>
    				Instant download of your product so you can get started right away!
    			</li><li>
    				We accept "<b>Paypal Only</b>" as Paypal protect our clients transaction...
    			</li>
    		</ul>
    		<p>
    			All products come with RR, MRR, or PLR Rights.
    		</p>
    
    		<div id="topSellers">
    			<h2>Top Sellers!<span></span></h2>
    			<ol>
    				<li>
    					<a href="view_item.php?id=108">
    						Preloaded ebook store 200 prodiucts Installed
    					</a>
    				</li><li>
    					<a href="view_item.php?id=107"">
    						You Ask It Yahoo Question Answer Clone PHP Script
    					</a>
    				</li><li>
    					<a href="view_item.php?id=106">
    						597 Business letters
    					</a>
    				</li><li>
    					<a href="view_item.php?id=105">
    						Wordpress 101
    					</a>
    				</li><li>
    					<a href="view_item.php?id=104">
    						Pet Rate Pro
    					</a>
    				</li><li>
    					<a href="view_item.php?id=103">
    						Auction Website!!!
    					</a>
    				</li><li>
    					<a href="view_item.php?id=102">
    						Ultimate 9000 articles pack
    					</a>
    				</li><li>
    					<a href="view_item.php?id=101">
    						Legal-Pages-Generator
    					</a>
    				</li><li>
    					<a href="view_item.php?id=100">
    						Transloader Script Resell Rights Included
    					</a>
    				</li><li>
    					<a href="view_item.php?id=99">
    						54 MYsql Databases Package
    					</a>
    				</li><li>
    					<a href="view_item.php?id=98">
    						The Internet Turnkey ebook
    					</a>
    				</li>
    			</ol>
    		<!-- #topSellers --></div>
    
    		<img
    			src="images/paypal_logo.gif"
    			width="117" height="35"
    			alt="paypal"
    			class="plate paypalLogo"
    		/>
    
    	<!-- #content, #contentWrapper --></div></div>
    
    	<div id="extras">
    
    		<div id="newsletterSignup">
    			<h2>Newsletter</h2>
    			<form method="post" action="mail.php">
    				<fieldset>
    					<label for="newsletterEmail">
    						Enter your e-mail address to sign up for our newsletter.
    					</label>
    					<input type="text" name="nEmail" size="20" />
    					<input type="submit" value="Go!" />
    				</fieldset>
    			</form>
    		<!-- #newsletterSignup --></div>
    
    		<div id="categories">
    			<h2>Categories</h2>
    			<ul>
    				<li><a href="categories4-Applications.htm">Applications</a></li>
    				<li><a href="categories7-EBooks.htm">EBooks</a></li>
    				<li><a href="categories3-Javascripts.htm">Javascripts</a></li>
    				<li><a href="categories5-Other.htm">Other</a></li>
    				<li><a href="categories1-PHP Scripts.htm">PHP Scripts</a></li>
    				<li><a href="categories8-Turnkey.htm">Turnkey</a></li>
    				<li><a href="categories9-Webmasters Top ten.htm">Webmasters Top ten</a></li>
    				<li><a href="categories6-Wordpress.htm">Wordpress</a></li>
    			</ul>
    		<!-- #categories --></div>
    
    		<div id="links">
    			<h2>Links</h2>
    			<ul>
    				<li><a href="http://scriptsgenie.com">http://scriptsgenie.com</a></li>
    			</ul>
    		<!-- #links --></div>
    
    	<!-- #extras --></div>
    
    	<hr />
    
    	<div id="footer">
    		<ul id="secondMenu">
    			<li><a href="/">Home</a></li>
    			<li><a href="view_cart.php">View Cart</a></li>
    			<li><a href="search.php">Search</a></li>
    			<li><a href="help.php">Help</a></li>
    			<li><a href="contact.php">Contact Us</a></li>
    		</ul>
    		&copy; 2013 The Dollar Store For Webmasters
    		<script type="text/javascript"><!--
    				google_ad_client = "ca-pub-6411604134848204";
    				google_ad_slot = "1728825901";
    				google_ad_width = 728;
    				google_ad_height = 90;
    		--></script>
    		<script
    			type="text/javascript"
    			src="http://pagead2.googlesyndication.com/pagead/show_ads.js"
    		></script>
    	<!-- #footer --></div>
    
    <!-- #pageWrapper --></div>
    
    </body></html>
    Code (markup):
    template.html - 6.1k

    EVERYTHING else you're doing there for layout belongs in an external stylesheet. I'm out the door for a late lunch, but when I get back I'll toss together some CSS to match that so you can see how we're supposed to have been writing a site in the post 1990's world.
     
    Last edited: Dec 21, 2013
    deathshadow, Dec 21, 2013 IP
  6. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #6
    ... and here's what I'm talking about:
    http://www.cutcodedown.com/for_others/sitescripts/template.html

    I also made a christmas version for laughs:
    http://www.cutcodedown.com/for_others/sitescripts/template2.html

    as with all my examples the directory:
    http://www.cutcodedown.com/for_others/sitescripts/

    is wide open for easy access to the gooey bits and pieces. Don't worry about it stealing your search mojo as it's behind a nofollow/noindex robots.

    I axed the background images in the top area as they aren't compatible with responsive layout or dynamic fonts... made a few minor changes to the markup I just posted to help make it more responsive. I'd suggest moving the google ad out of past the footer which is the COLDEST place on a site to put an advert -- If you change the settings to 160x800 in adsense you could make that a skyscraper either in the first sidebar at middling resolutions, in a THIRD sidebar with the paypal logo on really large displays, or below the content on really small displays.

    Shaves 140k and 18 files off what you had, greatly speeding up the page load time. The accessible markup will also make search engine's life a bit easier, I fixed the keywords to be relevant to the page -- while for the most part trying to adhere to the overall 'feel' you were going for.

    If I have time later I'll give you a breakdown of the HTML and CSS so you can learn from it, and start writing sites the proper way instead of working from outdated and broken methodologies... which is why you got the initial responses you did in this thread.

    I might rip on you for it, but I'm willing to explain it and show you how to do things 'better'.
     
    deathshadow, Dec 21, 2013 IP