My code doesn't work. Please have a look.

Discussion in 'PHP' started by JEET, May 12, 2006.

  1. #1
    Hi,
    What is wrong with this code? I get a blank page.
    I am basically trying to replace "," with "<br>" in a string which I don't know how long it is or how many times a "," appears.

    <?
    $var="my,name,is,jeet";
    $pieces = explode(",", $var);
    $n="0";
    $varn="";
    $v= $pieces['$n'];
    while($v != "")
    {
    $varn= $varn . "<br>" . $v;
    $n++;
    $v= $pieces['$n'];
    }
    echo $varn;
    ?>

    Please let me know what is wrong with it.
    Thank you
    jeet
     
    JEET, May 12, 2006 IP
  2. quaffapint

    quaffapint Active Member

    Messages:
    299
    Likes Received:
    6
    Best Answers:
    0
    Trophy Points:
    58
    #2
    Here you go...
    <?
    $var="my,name,is,jeet";
    $pieces = explode(",", $var);
    $n=0;
    $varn="";
    $v= $pieces[$n];
    while($v != "")
    {
    $varn= $varn . "<br>" . $v;
    $n++;
    $v= $pieces[$n];
    }
    echo $varn;
    ?>
    PHP:
    ...You were trying to turn $n into a string instead of using it as a number.

    -Matt
     
    quaffapint, May 12, 2006 IP
  3. kdb003

    kdb003 Active Member

    Messages:
    150
    Likes Received:
    5
    Best Answers:
    0
    Trophy Points:
    73
    #3
    An easer way to do this would be to use str_replace()
    http://us2.php.net/str_replace

    <?
    $var="my,name,is,jeet";
    echo str_replace(",","<br>",$var);
    ?>
    PHP:
     
    kdb003, May 12, 2006 IP
  4. quaffapint

    quaffapint Active Member

    Messages:
    299
    Likes Received:
    6
    Best Answers:
    0
    Trophy Points:
    58
    #4
    Wholeheartidly agree...:)
     
    quaffapint, May 12, 2006 IP
  5. frisby

    frisby Well-Known Member

    Messages:
    1,378
    Likes Received:
    39
    Best Answers:
    0
    Trophy Points:
    140
    #5
    Write <br /> and not <br>.
     
    frisby, May 12, 2006 IP
  6. JEET

    JEET Notable Member

    Messages:
    3,832
    Likes Received:
    502
    Best Answers:
    19
    Trophy Points:
    265
    #6
    Super ! Both your codes work just fine.
    I should be careful about those ' signs.
    Thank you so much for the help.
    Best wishes.
    jeet
     
    JEET, May 12, 2006 IP