I do it depending on the target audience. For instance, a myspace resource site would be a good site to exchange links with competitors. But most types of "stores" aren't good to do it with, you don't want to loose customers. So it just depends.
If a competitor and myself have a different focus, its a great exchange. For examlpe if we both sell red and blue widgets but I pay my bills by selling red and him blue.