JavaScript code not working

Discussion in 'JavaScript' started by rapt0r, Feb 24, 2010.

0
  1. #1
    Please can anyone help me with below script, I cannot see anything. I'am expecting to read five numbers between 1 and 30 and show For each number adjacent asterisks.

    <head>
    <title>Test</title>
    <script type="text/javascript">
    <!--
    var Num1;
    var Num2;
    var Num3;


    Num1 = 0;
    Num2 = 0;
    Num3 = 0;

    function promptNumbers()
    {
    var i, num, j;

    for(i=0;i<5;i++)
    {
    num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");

    while(isNaN(num))
    {
    num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
    }

    while(num < 1 || num > 30)
    {
    num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " , "0");
    while(isNaN(num))
    {
    num= windows.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
    }
    }

    for(j = 1;j<= num; j++)
    {
    document.writeln("*");
    }
    document.writeln("<br />");
    }
    }
    // -->
    </script>
    </head>

    <body></body>
    </html>
     
    rapt0r, Feb 24, 2010 IP
  2. s_ruben

    s_ruben Active Member

    Messages:
    735
    Likes Received:
    26
    Best Answers:
    1
    Trophy Points:
    78
    #2
    You have to call the function that you have written!!! :) Just add promptNumbers(); after the function and it will work!!!
     
    s_ruben, Feb 25, 2010 IP
  3. rapt0r

    rapt0r Peon

    Messages:
    7
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    0
    #3
    Thanks to your reply,
    I added this line promptNumbers(); after
    Num1 = 0;
    Num2 = 0;
    Num3 = 0;
    Still not working validation is successful, strange.

    Can you point out the code error.

    Thanks
     
    rapt0r, Feb 25, 2010 IP
  4. s_ruben

    s_ruben Active Member

    Messages:
    735
    Likes Received:
    26
    Best Answers:
    1
    Trophy Points:
    78
    #4
    I have just added promptNumbers(); after the function and it works fine. What doesn't work?
     
    s_ruben, Feb 25, 2010 IP
  5. rapt0r

    rapt0r Peon

    Messages:
    7
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    0
    #5
    I'm using Firefox 3.6, when i open the html file i don't get any prompts, blank page, can you verify that i did right below
    <script type="text/javascript">
    <!--
    var Num1;
    var Num2;
    var Num3;

    Num1 = 0;
    Num2 = 0;
    Num3 = 0;

    function promptNumbers(); (Here there was mistake right?)
    {
    var i, num, j;

    for(i=0;i<5;i++)
    {
    num = prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");

    while(isNaN(num))
    {
    num = prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
    }

    while(num < 1 || num > 30)
    {
    num = prompt("Enter Number" + (i+1) + " between 1 and 30 " , "0");
    while(isNaN(num))
    {
    num= prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
    }
    }

    for(j = 1;j<= num; j++)
    {
    document.writeln("*");
    }
    document.writeln("<br />");
    }
    }
    // -->
    </script>
    </head>

    <body></body>
    </html>
     
    rapt0r, Feb 25, 2010 IP
  6. s_ruben

    s_ruben Active Member

    Messages:
    735
    Likes Received:
    26
    Best Answers:
    1
    Trophy Points:
    78
    #6
    Here is the code that works fine:

    
<html>
<head>
<title>Test</title>
<script type="text/javascript">
var Num1;
var Num2;
var Num3;


Num1 = 0;
Num2 = 0;
Num3 = 0;

function promptNumbers()
{
var i, num, j;

for(i=0;i<5;i++)
{
num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");

while(isNaN(num))
{
num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
}

while(num < 1 || num > 30)
{
num = window.prompt("Enter Number" + (i+1) + " between 1 and 30 " , "0");
while(isNaN(num))
{
num= windows.prompt("Enter Number" + (i+1) + " between 1 and 30 " ,"0");
}
}

for(j = 1;j<= num; j++)
{
document.writeln("*");
}
document.writeln("<br />");
}
}

promptNumbers();
</script>
</head>

<body></body>
</html>
    Code (markup):
     
    s_ruben, Feb 25, 2010 IP
  7. rapt0r

    rapt0r Peon

    Messages:
    7
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    0
    #7
    Thank you so much it working now.
     
    rapt0r, Feb 25, 2010 IP