is this the right way to do?

it works the way i did but is it the right way? is there anyother way to do this?

thanks

		if ($newReference == "A001" or $newReference == "B001" or $newReference == "C001" $newReference == "D001" or $newReference == "E001" or $newReference == "F001" $newReference == "G001" or $newReference == "H001" or $newReference == "I001" $newReference == "J001" or $newReference == "K001" or $newReference == "L001" $newReference == "M001" or $newReference == "N001" or $newReference == "O001" $newReference == "P001" or $newReference == "Q001" or $newReference == "R001" $newReference == "S001" or $newReference == "T001" or $newReference == "U001" $newReference == "V001" or $newReference == "W001" or $newReference == "X001" $newReference == "Y001" or $newReference == "Z001")
        {
        $optitem = "OPTIMIZE TABLE item";
        $opt_item_table = mysql_query($optitem); 
		echo "optimised item table";
		
		$optorderr = "OPTIMIZE TABLE orderr";
        $opt_orderr_table = mysql_query($optorderr); 

		echo "optimised orderr table";
        }

PHP:

 

Instead of 'or' use the || operator, here's your code shortened.

<?php
  if ($newReference == "A001" || $newReference == "B001" || $newReference == "C001" $newReference == "D001" || $newReference == "E001" || $newReference == "F001" $newReference == "G001" || $newReference == "H001" || $newReference == "I001" $newReference == "J001" || $newReference == "K001" || $newReference == "L001" $newReference == "M001" || $newReference == "N001" || $newReference == "O001" || $newReference == "P001" || $newReference == "Q001" || $newReference == "R001" $newReference == "S001" || $newReference == "T001" || $newReference == "U001" $newReference == "V001" || $newReference == "W001" || $newReference == "X001" $newReference == "Y001" || $newReference == "Z001") {
      if(mysql_query("OPTIMIZE TABLE item") && mysql_query("OPTIMIZE TABLE orderr")){
      echo "Optimised 'item' & 'orderr' table";
      } else {
      echo "Error Optimizing!";
      }
  }
?>

PHP:

 

i used || before using or but it did not work. it did not optimize the tables

 

$newReference == "X001" $newReference == "Y001"

PHP:

I think you have a typo in your if statement, I'm suprised the optimization worked??

No wonder the || didn't work previously

 

thanks it works perfect.