innerhtml will swap once, but wont swap back

Discussion in 'JavaScript' started by DionDev, Nov 10, 2008.

  1. #1
    code:

    function loadnews()
    {
      document.getElementById('newshead').innerHTML = document.getElementById('newshead1').innerHTML;
      document.getElementById('newstext').innerHTML = document.getElementById('newstext1').innerHTML;
      document.getElementById('newsheadsub').innerHTML = document.getElementById('newshead2').innerHTML;
    }
    
    function swapnews()
    {
      if (document.getElementById('newshead').innerHTML = document.getElementById('newshead1').innerHTML)
      {
        document.getElementById('newshead').innerHTML = document.getElementById('newshead2').innerHTML;
        document.getElementById('newstext').innerHTML = document.getElementById('newstext2').innerHTML;
        document.getElementById('newsheadsub').innerHTML = document.getElementById('newshead1').innerHTML;
      }
      else
      {
        document.getElementById('newshead').innerHTML = document.getElementById('newshead1').innerHTML;
        document.getElementById('newstext').innerHTML = document.getElementById('newstext1').innerHTML;
        document.getElementById('newsheadsub').innerHTML = document.getElementById('newshead2').innerHTML;
      }
    }
    Code (markup):
    the body onload calls the "loadnews" function

    im trying to get it so that they can swap back and forth whenever the person clicks on the link containing the "swapnews" function

    so far it will only swap once, and wont swap back
     
    DionDev, Nov 10, 2008 IP
  2. rene7705

    rene7705 Peon

    Messages:
    233
    Likes Received:
    3
    Best Answers:
    0
    Trophy Points:
    0
    #2
    common error, one i make every now and then too ;)

    if (a = b) will SET a TO b, and return true if B wasn't null or undefined.
    if (a == b) will do what you want :)

    function loadnews()
    .....
    function swapnews()
    {
      if (document.getElementById('newshead').innerHTML == document.getElementById('newshead1').innerHTML)
      {
    .....
    }
    Code (markup):
     
    rene7705, Nov 11, 2008 IP