IF statement screwing up

I'm using the following code when entering data into a mysql database:

if ($regular == "no") { $hours = 0.00; }
$query = "INSERT INTO records VALUES('', '$user_id', '$regular', CURDATE(), '$day_of_week', '$month', '$year', '$hours', '$note', $nonreg_hours)";

Now if the $regular variable (sent via post) is 'no', the code works fine and the record is inserted into the db. HOWEVER, if $regular = 'yes', the insert query doesn't work. What am I doing wrong here?

 

Try this instead:

if ($_POST['regular'] == "no") { $hours = 0.00; }

PHP:

Peace,

 

Your SQL query is wrong, here's my recommendation:

$regular = $_POST['regular'];

IF( $regular == "no" ){

$curdate = CURDATE();

$hours = 0.00;

$query = mysql_query("INSERT INTO `records` (`user_id`, `regular`, `date`, `day_of_week`, `month`, `year`, `hours`, `note`, `nonreg_hours`) VALUES('$user_id', '$regular', '$curdate', '$day_of_week', '$month', '$year', '$hours', '$note', '$nonreg_hours')");

}ELSEIF( $regular == "yes" ){

// Type here what happens if it's "yes"

}

PHP:

 

Presumably the problem is because when $regular == 'yes', $hours is never set.

Try

$hours = ( $regular == 'no' ) ? 0.00 : '';

PHP:

(or replace the last '' with what $hours should equal when $regular is not no)

instead of
if ($regular == "no") { $hours = 0.00; }

 

He also has some syntax wrong.

 

The syntax is fine. CURDATE() is a mySQL function, not a PHP function - your code will just give fatal error function not defined.

The query could be improved (as you did) but that's just a best practice, not wrong.