I need help with this php code.

I have been struggling with this code, can anyone here help me on finding whats going wrong inside? Sorry I am a newbie, so not well versed with php.

 
  <?php if($countryid == '42'){ 
     echo "<a style=\"cursor:pointer;cursor:hand;\" onclick=\"MM_showHideLayers('popuptop','','show')\"><h2><?php echo $rowcat['catname']; ?><?php if($show_cat_adcount) { ?><span class=\"count\">(<?php echo $adcount; ?>)</span><?php } ?> </h2></a>";
    } 
    else {    
    echo "<a href=\"<?php echo $catlink; ?>\"><h2><?php echo $rowcat['catname']; ?><?php if($show_cat_adcount) { ?><span class=\"count\">(<?php echo $adcount; ?>)</span><?php } ?> </h2> </a>";
    }
    
    ?>

PHP:

 

You use the php code (<?php echo $rowcat['catname']; ?> for example) in the string. It isn't correct.
Instead of

echo "<h2><?php echo $rowcat['catname']; ?>";

PHP:

you should write something like

echo "<h2>".$rowcat['catname'];

PHP:

 

As stated by Nei, your <?php was not closed yet but you open a new <?php again

Another way to write the codes is:

<?php if ($countryid == '42'){ ?>
  <a style="cursor:pointer;cursor:hand;" onclick="MM_showHideLayers('popuptop','','show')"><h2><?php echo $rowcat['catname']; ?><?php if($show_cat_adcount) { ?><span class="count">(<?php echo $adcount; ?>)</span><?php } ?> </h2></a>
<?php } else { ?>  
  <a href="<?php echo $catlink; ?>"><h2><?php echo $rowcat['catname']; ?><?php if($show_cat_adcount) { ?><span class="count">(<?php echo $adcount; ?>)</span><?php } ?> </h2> </a>
<?php } ?>

PHP:

 

@Nei & ads2help

Thank you both! I am going to try this 2nite and will update!

Cheers
Dave

 

<?php 
	if($countryid == '42')
	{
     	echo "<a style='cursor:pointer;' onclick=\"MM_showHideLayers('popuptop','','show')\"><h2>".$rowcat['catname'];
		if($show_cat_adcount) 
		 	echo "<span class=\"count\">(".$adcount.")</span>";
		echo "</h2></a>";
	}
    else 
	{    
    	echo "<a href='$catlink'><h2>".$rowcat['catname'];
		if($show_cat_adcount) 
			echo "<span class='count'>(".$adcount.")</span>";
		echo "</h2> </a>";
    }   
?>

PHP:

 

<?php 
if($countryid == '42'){
echo "<a style=\"cursor:pointer;cursor:hand;\" onclick=\"".MM_showHideLayers('popuptop','','show')."\"><h2>".$rowcat['catname'];
if($show_cat_adcount) {
echo "<span class=\"count\">(".$adcount.")</span></h2></a>";
} 
}else{    
echo "<a href=\"".$catlink."\"><h2>";
echo $rowcat['catname'];
if($show_cat_adcount) {
echo "<span class=\"count\">(".$adcount.")</span></h2> </a>";
}
}
?>

PHP: