form validation with dynamic content

Discussion in 'PHP' started by LauroSkr, Nov 15, 2013.

  1. #1
    hi , so i have this one page makeFromTemplate.php ,that includes new page if neccesary based on the url


    
    <div >
    <h1 >text</h1>
    <ul class="subjects">
      
        <li><a href="makeFromTemplate.php?page=PAGE2" class="subject" >text</a></li>
        <li><a href="makeFromTemplate.php?page=PAGE3" class="subject">text</a></li>
        <li><a href="makeFromTemplate.php?page=PAGE4" class="subject">text</a></li>
         <li><a href="makeFromTemplate.php?page=PAGE5" class="subject" >text</a></li>
         <li><a href="makeFromTemplate.php?page=PAGE2" class="subject" >text</a></li>
        <li><a href="makeFromTemplate.php?page=PAGE3" class="subject">text</a></li>
        <li><a href="makeFromTemplate.php?page=PAGE4" class="subject">text</a></li>
    
        </ul>
    </div>
    
    
    <div id="loadedContent">
    
     
    <?php 
       if (isset($_GET ['page'])) {
           $p = $_GET ['page'];
         
          if(file_exists('PAGES/'.$p.'.php')){
           include 'PAGES/'.$p.'.php';
          }
    
          }
       ?>
    </div>
    PHP:

    then for example i have included the PAGE2.php and its content (see next code) shows in the makeFromTemplate.php and everything is ok


    <form action="http://localhost/makeFromTemplate/makeFromTemplate.php" name="foorm" method="GET">
    <input type="text" autocomplete="off" name="answer1"><br>
    <input type="text" autocomplete="off" name="answer2"><br>
    <input type="text" autocomplete="off" name="answer3"><br>
    <input type="text" autocomplete="off" name="answer4"><br>
    <input type="submit" name="roll" value="Make">
    
    
    </form>
    
    
    <?php
    
    
    if(isset($_GET['answer1'])&&isset($_GET['answer2'])&&isset($_GET['answer3'])&&isset($_GET['answer4'])){
        $answer1=$_GET['answer1'];
        $answer2=$_GET['answer2'];
        $answer3=$_GET['answer3'];
        $answer4=$_GET['answer4'];
    
    
                    if(!empty($answer1)&&!empty($answer2)&&!empty($answer3)&&!empty($answer4)&&!empty($answer5)&&!empty($answer6)&&!empty($answer7)&&!empty($answer8)){
    
    
                            $output= "Welcome $answer1 and $answer2 you all are my friends";
                            echo $output;
                          
                    }else{
                        echo "fill all fields,my friend!";
                    }
    }
    ?>
    PHP:

    but what i want is that
    1) include new page in makeFromTemplate.php (that works)
    2) echo $output variable in makeFromTemplate.php page from dynamically added page. (DOESNT WORK)

    forms action is falsy - because i dont know what to put there .

    when i include the page based on url everything is great and url is
    localhost/makeFromTemplate/makeFromTemplate.php?page=PAGE2

    but after i submit the form url is
    localhost/makeFromTemplate/makeFromTemplate.php?answer1=answer1&answer2=answer2&answer3=answer3&answer4=answer4&roll=Make


    can you help me?
     
    Last edited: Nov 15, 2013
    LauroSkr, Nov 15, 2013 IP
  2. nico_swd

    nico_swd Prominent Member

    Messages:
    4,153
    Likes Received:
    344
    Best Answers:
    18
    Trophy Points:
    375
    #2
    Input tags don't need to be closed in HTML 4. And the versions that require them to be closed, do it like this: <input />

    Inputs with the type "submit" will submit the form without Javascript. So adding the onclick event is completely redundant. Plus, it should be submit() as it's a method, and not a property.

    The maxlength attribute servers no security purpose because it can be removed by the user.

    Literally everything you suggest is a bad advice.
     
    nico_swd, Nov 17, 2013 IP
  3. PoPSiCLe

    PoPSiCLe Illustrious Member

    Messages:
    4,623
    Likes Received:
    725
    Best Answers:
    152
    Trophy Points:
    470
    #3
    Literally everything ezprint2008 has posted the last couple of days are complete crap advice, or bad coding. Be aware, I say. Might be just too little understanding, or it might be malicious - I dunno.
     
    PoPSiCLe, Nov 17, 2013 IP