Ok so a few days ago I joined these forums to get help on my template that I had just purchased. To make a long story short, I just ended up rewriting it with a lot of modifications. I didn't use, or even look at any of the old code once I started... with one exception, the navigation. I just didn't feel like rewriting that thing so I just copied and pasted. I have so far tested the browser in IE 7, Firefox 2, Safari 3, Netscape, Opera, but not IE 6 (oh god am I going to have problems ) I would really like a few of you to go through the code and pick it apart, giving me suggestions and fixes for things. I would really like review of the CSS code... it is such a mess because I had a short time to do this, and really rushed it, so I am sure there are many things that are there, that just don't need to be. I would also like some critical review of the design of the HTML and overall design (colors, etc.). All of the HTML pages have passed W3 validation, so don't bother running it through there. The site link is www.lamefilms.com although the actual site is going to be over at www.ennissteel.com, but don't go there, really you don't want to see there previous website... Again anything you bring to the table would be awesome! Thanks. CSS Files- www.lamefilms.com/css/layout.css www.lamefilms.com/css/style.css HTML Files- www.lamefilms.com/portfolio/index.html (I want all the pages checked, but this one has the most use of unnecessary <br /> tags and such...)
1. setting margins/padding manually is just a waste of time.. use a global reset 2. use font shorthand .. eg font:.688em Tahoma, sans-serif; but also have a backup incase Tahoma isnt supported like serif or sans-serif.. 3. for future purposes you dont have to avoid horizontal margins when floating, the fix for IE's double margins is display:inline; 4. if you're going to have one nav, give it an ID.. not a class 5. why are you giving padding on all 4 sides to a <b> ? 6. #ccc > #CCCCCC 7. padding:11px 0 0 > padding:11px 0 0 0
it all looks pretty good. I have 2 pretty minor things. 1-The div with class "navigation" could probably be completely removed, and assign the <ul> to "navigation". 2-Your CSS class "second" that is defined in the navigation menu is pointless. You don't have any styles defined under that class. Other than that, it looks really good.