Comments over-riding into the footer?

Discussion in 'CSS' started by le007, Dec 9, 2013.

  1. #1
    Don't know but the disqus comments are riding down into the footer - any suggestions please?

    I know it's a css problem but not sure what exactly it is!

    Here's the draft.
    http://theliberal.ie/leo/post-name-goes-here/

    Thanks guys,
    Leo
     
    le007, Dec 9, 2013 IP
  2. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #2
    Your markup seems to refer to 'clearfix' -- a common (half-assed) float clearing method, that does NOT exist in your CSS anywhere. You have a '.clear' property set in the CSS that seems to have clearfix's properties, and you don't seem to use it anywhere in the markup. Rename .clear to .clearfix in /themerush/style.css (or add .clearfix as another property to it) and that may fix the problem as right now, you're code's not clearing floats.

    Now, word of warning, I'm about to tell you something you probably aren't going to want to hear -- but even with the train wreck of idiotic code turdpress saddles you with, that theme goes above and beyond at being a laundry list of how not to build a website. It is blowing 30k of markup on 814 bytes of plaintext and three content images - easily two to four times as much code as should be present on such a simple page. The ungodly megabyte in total page size spanning 48 files for something so simple is indicative of really bad practices and code. That it has a massive mind-blowing 293k of CSS in 10 separate stylesheets leaves one begging the question "FOR WHAT?!?"

    Of course, most of that bloat in terms of markup and CSS comes from DIV for nothing, ID's and classes for nothing, HTML 5 bloat (not a fan)... but worst of all some stupid malfing 'grid' asshattery likely from some stupid framework. (Though I fail to recognize which one). It's mated to inaccessible undersized fixed metric fonts, px widths, and a host of other issues that to be brutally frank, means on design grounds ALONE I'd throw that in the trash and start over.

    ... and that's without talking the massive scripting code bloat of jquery garbage "FOR WHAT?!?"

    Though I'm also wondering, you've got a perfectly good turdpress setup capable of handling it's own commenting on pages, why the devil are you adding disqus to it?!?
     
    deathshadow, Dec 9, 2013 IP
  3. le007

    le007 Well-Known Member

    Messages:
    481
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    103
    #3
    Hi Deathshadow... long time no talk.

    Thanks for the reply, I know - you're right about the lingering lag that Wordpress consists off (what with its bulky way of doing things) - but on this particular project, I really need a WP theme. Would please PM me? I haven't a notion what I'm doing CSS-wise, I'd be very grateful if you could edit the aforementioned lines and get it actually working :/ I've been trying for a week now.

    Regarding Disqus, I need people to be able to login via their FB and Twitter accounts - it seems the easiest way!
     
    le007, Dec 10, 2013 IP
  4. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #4
    In this file:
    http://theliberal.ie/leo/wp-content/themes/themerush/style.css?ver=1.6

    find this:
    .clear {
    	clear:both;
    	display:block;
    	overflow:hidden;
    	visibility:hidden;
    	width:0;
    	height:0;
    }
    Code (markup):
    and try changing it to this:
    .clear,
    .clearfix {
    	clear:both;
    	overflow:hidden;
    	zoom:1;
    }
    Code (markup):
    That MAY do the job. Unsure though, there's so much going on there in the style it's hard to hammer down anything. You know how I said there's two to four times as much markup as should be needed? There's easily ten to twenty times as much CSS...
     
    deathshadow, Dec 10, 2013 IP
  5. le007

    le007 Well-Known Member

    Messages:
    481
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    103
    #5
    Deathshadow, how on earth did you manage to access that file? I can't even find it and I've access to the server?!?!?!?!?!
     
    le007, Dec 12, 2013 IP
  6. le007

    le007 Well-Known Member

    Messages:
    481
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    103
    #6
    PS Unfortunately it didn't work.
     
    le007, Dec 12, 2013 IP
  7. le007

    le007 Well-Known Member

    Messages:
    481
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    103
    #7
    It ALMOST is... but the problem now is that the disqus comments are now going underneath the footer?? Any suggestions please!

    Here's the issue:
    http://theliberal.ie/leo/hello-world-2/
     
    le007, Dec 12, 2013 IP
  8. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #8
    Did you get it? I'm not seeing the problem anymore here.

    Opera 12/lower's Info pane... (as opposed to the steaming pile of **** known as Chrome with the Opera logo slapped on it any old way... aka the pathetic crippleware known as Opera 15/newer). -- though one could just as easily get it through dragonfly, or firebug in FF, or the web developer toolbar for FF (which is more capable than in other browsers).
     
    deathshadow, Dec 12, 2013 IP
  9. le007

    le007 Well-Known Member

    Messages:
    481
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    103
    #9
    Ah, of course - forget about those add-ons. Yes, after reuploading it in an entirely new theme - it's working.

    Thanks very much Deathshahow, thanks for your help.
     
    le007, Dec 12, 2013 IP