can someone review this code

Discussion in 'CSS' started by judge0, Mar 2, 2008.

  1. #1
    i my try learning from this code is this templates coded very well
    if there any notice in html or css files
    css file

     
    judge0, Mar 2, 2008 IP
  2. wd_2k6

    wd_2k6 Peon

    Messages:
    1,740
    Likes Received:
    54
    Best Answers:
    0
    Trophy Points:
    0
    #2
    sorry what do you want reviewed, i'm not sure i quite understand?
     
    wd_2k6, Mar 2, 2008 IP
  3. shallowink

    shallowink Well-Known Member

    Messages:
    1,218
    Likes Received:
    64
    Best Answers:
    2
    Trophy Points:
    150
    #3
    Didn't look at the CSS. The html had enough for a short post. Too many DIVs. Using <strong> instead of h1,h2 or h3 tags. Using BRs instead of <p> </p>. The nav links aren't even in Lists which is pretty much standard practice. Overuse of DIVs , SPANs. I'm sure there's plenty more.
    Overall I wouldn't recommend it to learn good HTML practices. Figure the CSS is just as bad.
     
    shallowink, Mar 2, 2008 IP
  4. judge0

    judge0 Peon

    Messages:
    400
    Likes Received:
    9
    Best Answers:
    0
    Trophy Points:
    0
    #4
    Thanks for ur replying really that what i think about this templates but i hope to learn form this mistakes
     
    judge0, Mar 2, 2008 IP
  5. deathshadow

    deathshadow Acclaimed Member

    Messages:
    9,732
    Likes Received:
    1,999
    Best Answers:
    253
    Trophy Points:
    515
    #5
    Well, some FORMATTING might help, the use of spans seems completely inappropriate, the classnames seem to all be presentational instead of saying what it is they are actually marking up, the total lack of header tags, not marking paragraphs as paragraphs, overuse of break tags, etc make it fairly far off from proper markup techniques, the CSS has multiple redundant values inside it's own declarations and doesn't even SET line-heights, has no property condensing... and seems to be using floats and positioning on a bunch of stuff that I'm not even certain needs floats or positioning... and on my machine you're header text is blowing past the bottom of it's grey container box.

    Frankly, I'm surprised it validates... easily a quarter of the code present is unneeded/wasteful... though adding formatting would probably offset the savings slightly. (I'd ballpark the needed code to be, with formatting, about 4k even)

    Basically, I see all the telltales of coding the site appearance first instead of marking up the content sensibly first.

    Is that the type of 'review' you were asking for?
     
    deathshadow, Mar 2, 2008 IP
  6. judge0

    judge0 Peon

    Messages:
    400
    Likes Received:
    9
    Best Answers:
    0
    Trophy Points:
    0
    #6
    if u can give more details deeply in codes its be great
     
    judge0, Mar 2, 2008 IP