1. Advertising
    y u no do it?

    Advertising (learn more)

    Advertise virtually anything here, with CPM banner ads, CPM email ads and CPC contextual links. You can target relevant areas of the site and show ads based on geographical location of the user if you wish.

    Starts at just $1 per CPM or $0.10 per CPC.

Bug Bunch of warnings in log

Discussion in 'Better Analytics' started by vasikgreif, Sep 19, 2017.

  1. #1
    Hello, I see a bunch of undefined index warnings in log:

    Undefined index: time_on_page
    Undefined index: roles_no_track
    Undefined index: rss

    etc. Basically, if the setting is not filled/checked, you seem no to be checking with isset() if the array key is there.

    Any fix for this?
    Thanks
    V.
     
    vasikgreif, Sep 19, 2017 IP
  2. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,333
    Likes Received:
    2,613
    Best Answers:
    462
    Trophy Points:
    710
    Digital Goods:
    29
    #2
    Can you post the full error log for those?
     
    digitalpoint, Sep 19, 2017 IP
  3. vasikgreif

    vasikgreif Peon

    Messages:
    3
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    1
    #3
    Hello, ie:
    Undefined index: roles_no_track, Line: 318, File:/var/www/html/assets/plugins/better-analytics/library/DigitalPointBetterAnalytics/Base/Public.php
     
    vasikgreif, Sep 19, 2017 IP
  4. digitalpoint

    digitalpoint Overlord of no one Staff

    Messages:
    38,333
    Likes Received:
    2,613
    Best Answers:
    462
    Trophy Points:
    710
    Digital Goods:
    29
    #4
    digitalpoint, Sep 19, 2017 IP
  5. vasikgreif

    vasikgreif Peon

    Messages:
    3
    Likes Received:
    0
    Best Answers:
    0
    Trophy Points:
    1
    #5
    This was in a custom error handler. There is a bunch of reasons why to avoid using of @ operator, some of them ie. here: https://derickrethans.nl/five-reasons-why-the-shutop-operator-should-be-avoided.html. Would be cool to rewrite the code to not use the @ operator I think.
     
    vasikgreif, Oct 7, 2017 IP