php script problem

I am trying to modify a simple php script but I can't get the variation to work.

Can someone take a look please, I am sure it's simple but I know very little about php.

Thanks!

The problem is that the first one below doesn't work, while the second one does, what's the reason if any?

<?
$imagevar=rand(1, 10);
if($imagevar==1) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==2) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==3) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==4) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==5) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==6) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==7) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==8) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==9) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
else if($imagevar==10) { print "<img src="http://www.xxx.yyy/zzz.jpg">";}
?>


<?
$imagevar=rand(1, 4);
if($imagevar==1) {print "<img src='xxx.jpg'>";}
else if($imagevar==2) {print "<img src='xxx.jpg'>";}
else if($imagevar==3) {print "<img src='xxx.jpg'>";}
else if($imagevar==4) {print "<img src='xxx.jpg'>";}
?>

Thanks again.

 

You have double "" in your first code, try adding slashes like this
print "<img src=\"http://www.xxx.yyy/zzz.jpg\">";

or change to '

 

Thanx Alx!

I'm not sure if that was the only reason, but I got it to work!

 

yes that was the only reason. u shd escape double quotes ( " --> \" ) when used inside a string.

 

or instead of the \" slashes you could use single quotes like <a href='hhh.htm'>

 

but using single quotes will viloate xhtml validation if he is using it. xhtml speicfies that tag parameter values should be enclosed in double quotes.

 

single quotes can be used like this:
print '<img src="http://www.xxx.yyy/zzz.jpg">';

 

Might want to try something like this:

$images = array( 1 => 'http://www.xxx.yyy/zzz.jpg',
    2 => 'http://www.xxx.yyy/zzz.jpg',
    3 => 'http://www.xxx.yyy/zzz.jpg',
    4 => 'http://www.xxx.yyy/zzz.jpg',
    5 => 'http://www.xxx.yyy/zzz.jpg',
    6 => 'http://www.xxx.yyy/zzz.jpg',
    7 => 'http://www.xxx.yyy/zzz.jpg',
    8 => 'http://www.xxx.yyy/zzz.jpg',
    9 => 'http://www.xxx.yyy/zzz.jpg',
   10 => 'http://www.xxx.yyy/zzz.jpg' );

$imagevar=rand(1, count($images));
printf("%s",$images[$imagevar]);

Code (markup):

This way you just need to add new images into the array.