PHPLD Bug (Deals with RSS Feeds)

Discussion in 'Directories' started by paidhosting, Aug 26, 2007.

0
  1. #1
    Hello,
    I just pmed Chris about it but than i realized that its an inherent problem with all PHPLD directories.

    Ok visit

    http://www.alivedirectory.com/

    http://www.nobledirectory.com/

    http://www.h-log.com/

    Or infact any PHPLD directory with Rss Enabled.

    Now go to Latest Links or Top Links Section, hit the Address bars feed icon on the right (the orange colored feed icon that in address bar).

    You will be redirected to following pages

    http://www.alivedirectory.comrss.phppage-1.html/

    http://www.nobledirectory.comrss.phppage-1.html/

    and

    http://www.h-log.com/rss.phppage-1.html


    But if you click on the XML image on the site itself it redirects properly to the feed, but address bar feed link is messed up and i will post this bug also at phpld forums so david is aware of it.

    By the way if wondering why the hell or how the hell paidhosting found out ?

    Well i was working with my review site and was testing a new feature which allows directory owners who provide interviews to send me their rss feed link so the directory review site can display their feeds , example : http://www.webdirectoryreviews.com/php-test/

    Cheers
     
    paidhosting, Aug 26, 2007 IP
    msolution likes this.
  2. smub

    smub Notable Member

    Messages:
    3,443
    Likes Received:
    375
    Best Answers:
    0
    Trophy Points:
    230
    #2
    umm u posted the problem .... do u have a fix for it ??
     
    smub, Aug 26, 2007 IP
  3. paidhosting

    paidhosting Peon

    Messages:
    4,822
    Likes Received:
    483
    Best Answers:
    0
    Trophy Points:
    0
    #3
    I am not david am i :D:p ,if it were my script i would have.

    But strange no one noticed it before :eek:
     
    paidhosting, Aug 26, 2007 IP
  4. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #4
    Nice error found.. i never noticed it!

    Its in my dir, and i dont know :rolleyes:
    Thanks for letting us know, will be waiting for a fix :)
     
    sizzler_chetan, Aug 26, 2007 IP
  5. smub

    smub Notable Member

    Messages:
    3,443
    Likes Received:
    375
    Best Answers:
    0
    Trophy Points:
    230
    #5
    fixed in my Web Directory

    thanks alot paidhosting for pointing the error out
     
    smub, Aug 26, 2007 IP
  6. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #6
    Care to share how to fix it?

    I am bad at these things!
     
    sizzler_chetan, Aug 26, 2007 IP
  7. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #7
    This was posted by Dan from Virtual Solutions over at the phpLD forum:


    "Missing trailing forward slash at end of Site URL (set via phpLD Admin > Settings > Site > {URL}). URL to rss.php in header.tpl (that browser picks up on) uses absolute URL - using SITE_URL. Other (top_bar.tpl I believe) is relative URL that would not be affected by this. Just edit {URL} by adding forward slash (/) to end."
     
    proprod, Aug 27, 2007 IP
  8. paidhosting

    paidhosting Peon

    Messages:
    4,822
    Likes Received:
    483
    Best Answers:
    0
    Trophy Points:
    0
    #8
    Sorry couldnt understand you, and i do have a / after url under sites setting it looks like
    http://www.h-log.com/ to be exact.
     
    paidhosting, Aug 27, 2007 IP
  9. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #9
    Hmmm, ok then. I will report this back over at phpLD. We'll have a fix soon :)

    EDIT: I've checked my Premium Directory and same problem... I will take a look at the rss.php code and report back either in a few here or by tomorrow if someone else hasn't.
     
    proprod, Aug 27, 2007 IP
  10. msolution

    msolution Well-Known Member

    Messages:
    1,182
    Likes Received:
    123
    Best Answers:
    0
    Trophy Points:
    175
    #10
    Ok which browser are you people using, and are there any plugins installed!

    coz i cant see the feed icon (in FF) for any of the above mentioned sites

    to have that icon, by me, u have to have 

    
<link href="..." rel="alternate" type="application/rss+xml" title="Dir.vc" />
    Code (markup):
    in your <head> tag! and i dont see that in any site!

    lemme know what im missing!

    Thanx for bringing this up!

    M.
     
    msolution, Aug 27, 2007 IP
  11. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #11
    What phpLD version are you running?
     
    proprod, Aug 27, 2007 IP
  12. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #12
    I am using FireFox 2.0.0.6. You have to have RSS enabled on your directory. The icon will show up on the very far right of the bar where you type your addresses.

     
    proprod, Aug 27, 2007 IP
  13. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #13
    sizzler_chetan, Aug 27, 2007 IP
  14. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #14
    Ok, good... here's my fix for v3.2

    In header.tpl, locate on or around line 36:

    {* Live Bookmarks *}
   {if $smarty.const.ENABLE_RSS and (!empty($search) or $category.ID gt 0 or $list) and count($links) gt 0}
      <link rel="alternate" type="application/rss+xml" title="{$in_page_title|escape|trim}" href="{$smarty.const.SITE_URL}rss.php&#63{if !empty($search)}search={$search|@urlencode}{elseif $p}p={$p}{elseif $list}list={$list}{else}c={$category.ID}{/if}" />
   {/if}
    Code (markup):
    Replace with:

    {* Live Bookmarks *}
   {if $smarty.const.ENABLE_RSS and (!empty($search) or $category.ID gt 0 or $list) and count($links) gt 0}
      <link rel="alternate" type="application/rss+xml" title="{$in_page_title|escape|trim}" href="{$smarty.const.DOC_ROOT}/rss.php?{if !empty($search)}search={$search|@urlencode}{elseif $list}list={$list}{else}c={$category.ID}{/if}{if $sort}&amp;s={$sort}{/if}{if $p}&amp;p={$p}{/if}" />
   {/if}
    Code (markup):
    Let me know how this works.
     
    proprod, Aug 27, 2007 IP
    MarRome likes this.
  15. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #15
    sizzler_chetan, Aug 27, 2007 IP
  16. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #16
    Same fix should work for 3.1

    The code may be on a different line, but will be the same.


     
    proprod, Aug 27, 2007 IP
  17. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #17
    It worked :)

    Check Latest Links and Top Hits :D

    Thanks!
     
    sizzler_chetan, Aug 27, 2007 IP
  18. proprod

    proprod Active Member

    Messages:
    216
    Likes Received:
    11
    Best Answers:
    0
    Trophy Points:
    90
    #18
    Great! Glad I could help out... hopefully Chris and other phpLD users will see this thread. To be quite honest, I've never clicked the RSS icon up there, so never noticed it, props (no pun intended) to paidhosting for catching it! Still waiting to hear back to make sure it worked for you, paidhosting :)

    I've also posted the fix at the phpLD forums, so it should be included in future releases along with the suggestion from vsdan forcing a trailing backslash.
     
    proprod, Aug 27, 2007 IP
  19. sizzler_chetan

    sizzler_chetan Prominent Member

    Messages:
    7,838
    Likes Received:
    664
    Best Answers:
    0
    Trophy Points:
    390
    #19
    Actually i too never click on the feed icon of the browser, anyways thanks for paidhosting showing error in my dir, and proprod for the fix :D
     
    sizzler_chetan, Aug 27, 2007 IP