nice product jquery based image viewer

Discussion in 'jQuery' started by brightyoursite, Feb 22, 2010.

  1. #1
    brightyoursite, Feb 22, 2010 IP
  2. brightyoursite

    brightyoursite Peon

    Messages:
    59
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    0
    #2
    any suggestions please let me know thanks


    more usefull tools :
     
    brightyoursite, Feb 22, 2010 IP
  3. brightyoursite

    brightyoursite Peon

    Messages:
    59
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    0
    #3
    you review is important for me
     
    brightyoursite, Feb 25, 2010 IP
  4. dimitar christoff

    dimitar christoff Active Member

    Messages:
    882
    Likes Received:
    62
    Best Answers:
    0
    Trophy Points:
    90
    #4
    this is a bit more than what i'd need, i would not call it 'simple'. the zooming is nice, you can bind this to mousehweel which would be cool. what is NOT useful is the drag/move functionality, just adds overhead and i fail to see why you'd want to move the image within the modal window?
    also, the animations/tweens seem slow and choppy for me in firefox (but that's due to jquery's lack of pseudo FPS controls) - for instance the fade out or the reduce /increment size feels off.

    one thing i would suggest is, do the demo on a very tall page, like 7000px+ to see how your modal window will perform there and especially so in IE which has trouble with applying an opacity filter over elements of this kind of size (i am not sure on the exact size that was breaking but it was doing this on my blog)

    and the next/previous can be an option but make sure it's exactly that, an option.

    looking at the source, you are exporting a bunch of functions into the global namespace (unnecessary imo), use a closure and as a whole, try to bring them all in as internal methods as you extend jquery instead.

    good luck - keep up the good work :) i hope you take this as simple constructive feedback, i am only pointing out things that can be improved upon, you already know what you like about it anyway.
     
    dimitar christoff, Feb 25, 2010 IP
  5. brightyoursite

    brightyoursite Peon

    Messages:
    59
    Likes Received:
    1
    Best Answers:
    0
    Trophy Points:
    0
    #5
    yes the mousehweel is whats in my mind .for othere suggestions i will test it again and try to make it perfect . thanks for you suggestions
     
    brightyoursite, Feb 25, 2010 IP