This is my first website. Any tips or suggestions would be greatly appreciated! Thanks! www.greatdealguru.com
Wow thanks guys, I was expecting the worst haha. I made a few tweaks to it, and I still need to get captcha. Any other feedback would be great!
I've seen that theme way too many times to make the site look interesting.. If you're not comfortable starting from scratch and you like that theme, you need to tweak it a bit to be more unique and relevant to your site. For example have an actual logo at the top (image) instead of just text, and changing the background wouldn't be a bad idea
That is a good idea, I'm going to look for a nice image to put as my logo. And I will look into other ways of making my site unique. Thanks for the feedback everybody
It is looking ok, there is 1 simple error in the XHTML validation: Line 57, Column 133: Attribute "border" exists, but can not be used for this element.
I also have seen that theme way too much. Add some uniqueness to it and you will stand out with the theme. Other than that, the blog is nice overall, so there's nothing to worry about.
Fixed metric fonts are an accessability /FAIL/, fixed width layout is not netbook or other mobile device friendly, it's not entirely clear where each article starts/ends (needs more padding), and the text in the search bar is illegible due to being too low a contrast to the background. It appears to be designed in XHTML 1.1 which there is no point to even be trying to do given IE's complete lack of support for it - it brings nothing to the table in terms of cross-browser deployment that 1.0 STRICT doesn't, and it can introduce rendering errors like those I'm seeing in IE6 - though those errors could also be blamed on the placement of the semi-pointless comments. I'm seeing clearing div's, unnecessary DIV's and Classes all over the place, and a whole host of other issues that really should be cleaned up. The layout seems to work (for now) in all modern browsers EXCEPT IE, where on my system it appears to be slightly broken on a few things in IE8 - and it's next to useless in IE6 and 7 from the disappearing content and double-render bugs tripped by the comment placement. The commenting is the pinnacle of wasteful redundant bad comments too... <!-- wrap START --> <div id="wrap"> <!-- container START --> <div id="container" > <!-- header START --> <div id="header"> Code (markup): Really? Opening a tag with an ID is the start of a section with the same name? Who'd have thought!?! Comments between elements if floats are involved can make both IE6 and IE7 completely wierd out. Hence, it's usually a good idea to not bother with the pointless redundant comments at the start like you have above, and when it comes to closing the elements instead of this: </div> <!-- header END --> Code (markup): use this <!-- #header --></div> Code (markup): We know it's the end - that's what </div> means. Moving the comment before the close prevents the comment from ending up in-between elements and therein preventing the IE comment render bugs. As to the rest, it's not bad... For all the above comments I've seen far worse as you've not got an unreasonable layout, the color choices (except for the dark backround on the search) are quite nice, and the use of visual eye-candy is done tastefully and does not overpower the important part of the page - the content.